Warn when Cargo.toml contains keys we don't expect #13833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/cargo-warn-on-extra-keys
branch
from
4ddcd3b
to
5769074
Compare
xclaesse
reviewed
Nov 1, 2024
This allows us to move a bit of the validation and fixing into these classes
dcbaker
force-pushed
the
submit/cargo-warn-on-extra-keys
branch
3 times, most recently
from
74ac291
to
75fa7d6
Compare
Cargo sometimes adds new keys and Meson needs to gracefully handle those. Currently, an unknown key will trigger an uncaught Python exception, which is pretty much the worse case. With this change Meson will instead issue a warning much like the one for unknown cpu architectures. See mesonbuild#13826 for the motivation for this change
dcbaker
force-pushed
the
submit/cargo-warn-on-extra-keys
branch
from
75fa7d6
to
408bde7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents use from having uncaught python exceptions when a new key is added, as one recently was. The downside of course of warning is that we might configure incorrectly. At the moment I think that is the preferable way to go, especially since Cargo support is experimental and may fail anyway.