Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: allow input from stdin #13793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

format: allow input from stdin #13793

wants to merge 1 commit into from

Conversation

bruchar1
Copy link
Member

Fixes #13791

dcbaker
dcbaker requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit about error messages.

How does this work with finding meson.format, since that's based on paths?

mesonbuild/mformat.py Outdated Show resolved Hide resolved
@bruchar1
Copy link
Member Author

bruchar1 commented Nov 4, 2024 •
edited
Loading

How does this work with finding meson.format, since that's based on paths?

Parent path of Path('-') will be current working directory. Therefore, it will look for meson.format in the current working directory. Does it make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbaker dcbaker dcbaker requested changes

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
tool:format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Accept stdin as argument to format
2 participants
@bruchar1 @dcbaker