Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor option getting v2 #13441

Open
wants to merge 104 commits into
base: master
Choose a base branch
from
Open

Refactor option getting v2 #13441

wants to merge 104 commits into from

Commits on Nov 5, 2024

  1. Refactor getting target options to a dedicated method.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    569536a View commit details
    Browse the repository at this point in the history

  2. Move option querying to coredata so it can be shared.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7f8ba9b View commit details
    Browse the repository at this point in the history

  3. Refactor code to use per-target option methods.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a8fa34c View commit details
    Browse the repository at this point in the history

  4. Convert more usages to per-target methods.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d2a3f91 View commit details
    Browse the repository at this point in the history

  5. Convert more usages to per-target methods.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    39c4129 View commit details
    Browse the repository at this point in the history

  6. Convert more usages to per-target methods.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bd96bfb View commit details
    Browse the repository at this point in the history

  7. Convert more usages to per-target methods.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6045f22 View commit details
    Browse the repository at this point in the history

  8. Convert more usages to per-target methods.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d176894 View commit details
    Browse the repository at this point in the history

  9. Refactor getting option value to its own method.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    32a7b6d View commit details
    Browse the repository at this point in the history

  10. Refactor option overriding code.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3b693ad View commit details
    Browse the repository at this point in the history

  11. Fix std lookup in subprojects.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c1fc3e4 View commit details
    Browse the repository at this point in the history

  12. Can specify per-subproject options from the command line.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    84ce0f9 View commit details
    Browse the repository at this point in the history

  13. Add enough override functionality to pass override unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    cdf8b2e View commit details
    Browse the repository at this point in the history

  14. Update tests and find new roadblock.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e9257c2 View commit details
    Browse the repository at this point in the history

  15. Pass original strings to setter method.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1d1a5fd View commit details
    Browse the repository at this point in the history

  16. Rebasing fix.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2a8ba99 View commit details
    Browse the repository at this point in the history

  17. Persp override test works. Other tests do not.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    21586c0 View commit details
    Browse the repository at this point in the history

  18. Start working on an option store class.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4cd8d9e View commit details
    Browse the repository at this point in the history

  19. Write more tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fe34853 View commit details
    Browse the repository at this point in the history

  20. Implement augments in OptionStore.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8d5b189 View commit details
    Browse the repository at this point in the history

  21. Add some more tests and functionality to OptionStore.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a7ce0e6 View commit details
    Browse the repository at this point in the history

  22. Hook up new option store to the old code. Can compile simple projects.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ca35970 View commit details
    Browse the repository at this point in the history

  23. Preserve default options in the original string form.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2e3382a View commit details
    Browse the repository at this point in the history

  24. Fix things, 73 failing common tests remaining.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8dca103 View commit details
    Browse the repository at this point in the history

  25. Fix all visible tracebacks from accessing coredata.options for common… 

    … tests.
    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    551211e View commit details
    Browse the repository at this point in the history

  26. Preserve command line options as strings all the way until OptionStore.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ed65bac View commit details
    Browse the repository at this point in the history

  27. Fix option object usage.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    486b2ac View commit details
    Browse the repository at this point in the history

  28. Fix more option code paths.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9cddcad View commit details
    Browse the repository at this point in the history

  29. More option fixes.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    dfd1406 View commit details
    Browse the repository at this point in the history

  30. More option fixing.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ff4ed1d View commit details
    Browse the repository at this point in the history

  31. Fix configure command enough to print values and augments.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    efbdd74 View commit details
    Browse the repository at this point in the history

  32. Start getting option data from optstore.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2e21f8a View commit details
    Browse the repository at this point in the history

  33. Keep the new optionstore around.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b15ccb1 View commit details
    Browse the repository at this point in the history

  34. Fix a few more files.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3213b5d View commit details
    Browse the repository at this point in the history

  35. Fix some options.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0e63815 View commit details
    Browse the repository at this point in the history

  36. Fix errors of mega rebase enough to compile trivial test project.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ce772b5 View commit details
    Browse the repository at this point in the history

  37. More fixes.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1cc1a1e View commit details
    Browse the repository at this point in the history

  38. Fix option unit tests. But break everything else.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    95426e0 View commit details
    Browse the repository at this point in the history

  39. Fix a bunch of failing common project tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    45eb7c2 View commit details
    Browse the repository at this point in the history

  40. Always initialize compilers in the same order.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    137c9b4 View commit details
    Browse the repository at this point in the history

  41. Fix CMake project tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e069a11 View commit details
    Browse the repository at this point in the history

  42. Fix pending options.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8aee56d View commit details
    Browse the repository at this point in the history

  43. Fix options in project() call.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    00668ce View commit details
    Browse the repository at this point in the history

  44. Use set_value method rather than poking the dict directly.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    24aeb65 View commit details
    Browse the repository at this point in the history

  45. Move deprecation handling in OptionStore.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a92a602 View commit details
    Browse the repository at this point in the history

  46. Fix options so that all common tests now pass.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fd010ef View commit details
    Browse the repository at this point in the history

  47. Temporary fix for failing test.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a05481d View commit details
    Browse the repository at this point in the history

  48. Made build options fall back to regular ones when not cross compiling.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7b04d91 View commit details
    Browse the repository at this point in the history

  49. Fix project tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1443791 View commit details
    Browse the repository at this point in the history

  50. Fix some unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3f6d7cb View commit details
    Browse the repository at this point in the history

  51. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5d4c834 View commit details
    Browse the repository at this point in the history

  52. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0e66574 View commit details
    Browse the repository at this point in the history

  53. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9c3bb68 View commit details
    Browse the repository at this point in the history

  54. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    070c19e View commit details
    Browse the repository at this point in the history

  55. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    090ce81 View commit details
    Browse the repository at this point in the history

  56. Convert named options to corresponding -D options.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b69d95f View commit details
    Browse the repository at this point in the history

  57. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a7f4186 View commit details
    Browse the repository at this point in the history

  58. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    60734d0 View commit details
    Browse the repository at this point in the history

  59. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7beadc1 View commit details
    Browse the repository at this point in the history

  60. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    caf5947 View commit details
    Browse the repository at this point in the history

  61. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4157e87 View commit details
    Browse the repository at this point in the history

  62. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0050d68 View commit details
    Browse the repository at this point in the history

  63. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    745ad65 View commit details
    Browse the repository at this point in the history

  64. Fewer than 20 failing unit tests remaining.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6e0e998 View commit details
    Browse the repository at this point in the history

  65. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a5d1dc1 View commit details
    Browse the repository at this point in the history

  66. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    db4a992 View commit details
    Browse the repository at this point in the history

  67. Disable test that is no longer meaningful.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f5e4476 View commit details
    Browse the repository at this point in the history

  68. Handle machine type correctly.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    61ca065 View commit details
    Browse the repository at this point in the history

  69. Fix initializing prefix dependent options.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    94aabdf View commit details
    Browse the repository at this point in the history

  70. Fix a few unit tests and more fail than before.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    cdff21d View commit details
    Browse the repository at this point in the history

  71. Fix unit tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7e5e1b0 View commit details
    Browse the repository at this point in the history

  72. Use OptionKey instead of strings.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    27acdca View commit details
    Browse the repository at this point in the history

  73. Add per-subproject options in machine files to augments.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    df00872 View commit details
    Browse the repository at this point in the history

  74. Disable and alter some failing tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ba346ed View commit details
    Browse the repository at this point in the history

  75. ALL TESTS PASS! On this machine.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3d862fc View commit details
    Browse the repository at this point in the history

  76. Fix some failing CI tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    91a4eca View commit details
    Browse the repository at this point in the history

  77. Vala fix.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    35cad78 View commit details
    Browse the repository at this point in the history

  78. Fix some Clang tests.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    82ce69e View commit details
    Browse the repository at this point in the history

  79. Fix VS code.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    79aa83c View commit details
    Browse the repository at this point in the history

  80. Fix the VS backend a bit.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    46753dc View commit details
    Browse the repository at this point in the history

  81. Fix Objective C/C++.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5c02f72 View commit details
    Browse the repository at this point in the history

  82. Fix some Windows issues.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    eb855f1 View commit details
    Browse the repository at this point in the history

  83. Fix unity issues.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    49ee948 View commit details
    Browse the repository at this point in the history

  84. Fix Cuda options.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    498e7f7 View commit details
    Browse the repository at this point in the history

  85. Fix Windows things.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    aa91c02 View commit details
    Browse the repository at this point in the history

  86. Fix Mac bitcode warning.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7c523e6 View commit details
    Browse the repository at this point in the history

  87. Fix vslite generation.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2aae29a View commit details
    Browse the repository at this point in the history

  88. Windows fixes.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    128bf39 View commit details
    Browse the repository at this point in the history

  89. Fix cross compilation.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    fab5a01 View commit details
    Browse the repository at this point in the history

  90. Fortran fixes.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    25b1005 View commit details
    Browse the repository at this point in the history

  91. Set debug and opt based on buildtype changes.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2002cdb View commit details
    Browse the repository at this point in the history

  92. Fix typing.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4c481c4 View commit details
    Browse the repository at this point in the history

  93. Fix annotations for C compilers.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8caafa4 View commit details
    Browse the repository at this point in the history

  94. Fix annotations for C++ compilers.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6ab4d31 View commit details
    Browse the repository at this point in the history

  95. Add more annotations.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b011005 View commit details
    Browse the repository at this point in the history

  96. Add more annotations.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2613d7c View commit details
    Browse the repository at this point in the history

  97. Add more annotations.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    34fe03d View commit details
    Browse the repository at this point in the history

  98. Fix annotations.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8211f75 View commit details
    Browse the repository at this point in the history

  99. Fix pylint issues.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    cd64e53 View commit details
    Browse the repository at this point in the history

  100. Fix flake8 issues.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    518a1d9 View commit details
    Browse the repository at this point in the history

  101. Refactor option evaluation to a single method.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    134e70a View commit details
    Browse the repository at this point in the history

  102. Group getter and setter methods together.

    @jpakkane
    jpakkane committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3a139b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Move configure option -A functionality to -D.

    @jpakkane
    jpakkane committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    0fe1254 View commit details
    Browse the repository at this point in the history

  2. Add documentation for per-subproject options.

    @jpakkane
    jpakkane committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    9d5594c View commit details
    Browse the repository at this point in the history