Revert "Add role to NodeInfo/Lite" #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
requested review from
caveman99,
garthvh,
sachaw,
ajmcquilkin,
andrekir,
jp-bennett and
code8buster
|
Why does this need to go in user? This doesn't feel like something that's specific to the user of the radio |
User is what the NodeInfoModule actually allocates for the payload. It's part of the issue with the current architecture that we want to break out for 3.0. User will be completely decoupled from NodeInfo then. |
sachaw
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #405
As smoke pointed out, this actually needs to go onto User which is what NodeInfoModule allocates in the meshpacket payload. Meh!