Out of the box for Arduino IDE #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundles NanoPB Bumps NanoPB to 0.4.9 Remove device only proto, to avoid std::vector on ESP8266
Changes by create-pull-request action
Removes external dependency on plerup/espsoftwareserial, as the ESP8266 arduino core comes bundled with a software serial library.
This is one specific debug log message which is printed repeadetly during connection. It causes the serial input buffer to overflow while we attempt to repeatedly print at 9600 baud.
GUVWAF
approved these changes
Nov 11, 2024
thebentern
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should allow direct installation from the Arduino IDE library manager.
Removes additional setup steps which were previously required.
Tested with ESP32 and ESP8266. Untested with Uno R4 and SAMD targets.
GitHub Action now bundles NanoPB with library
Removes setup step
Device Only protos excluded during regen
Avoids reference to
std::vector. Problematic with ESP8266(?)ESP32 uses Serial1 instead of software serial
Removes library dependency
Please let me know if you spot anything concerning, particularly with the GitHub Action and changes to ProtoBufs, as I'm less confident there.
Note: The generated files checked in here are from the workflow file included in this PR.
(https://github.com/todd-herbert/meshtastic-arduino/actions/runs/11764203481)
Not sure what the etiquette is in this case.