Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve PersistedQueryProvider types #1121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: improve PersistedQueryProvider types #1121

wants to merge 2 commits into from

Conversation

marcoreni
Copy link

While implementing a custom PersistedQueryProvider, we noticed that the types were not correct for the "getQueryFromHash" function. In fact, the function may return undefined if the query does not exist, but as of now the types do not allow that.

This PR fixes this (small) issue.

mcollina
mcollina requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd for types

mcollina
mcollina approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoreni @mcollina