Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error through subscription wrapped in an array #1105

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Moonnz
Copy link
Contributor

@Moonnz Moonnz commented Aug 9, 2024

The graphql-ws protocol specifies that the payload of an 'error' message should be an array of GraphQL errors. (ref)

To accommodate this, I created the sendError function to manage the transformation and updated all related tests accordingly.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4de34c7 into mercurius-js:master Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants