Add a shim for grep-edit #656
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on some improvements to simplify the shims at #664. |
|
Thanks, I'll checkout #664 and see if this PR is still necessary. |
|
I think for now it's still necessary. But I want to remove the need somehow. |
gs-101
force-pushed
the
shim-grep-edit
branch
from
eba43ff
to
0d7c391
Compare
grep-edit is a major mode introduced in Emacs 31 which enables the editing of Grep results, by typing 'e' in '*grep*' buffers. 'C-c C-c' exits this mode and saves changes.
gs-101
force-pushed
the
shim-grep-edit
branch
from
0d7c391
to
cca68db
Compare
|
Second force-push was because the commit had unintentional indentation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grep-editis a major mode introduced in Emacs 31 (introduced in commit db1eb8a2) which enables the editing of Grep results, by typingein*grep*buffers.C-c C-cexits this mode and saves changes. It can be used as a built-in replacement of wgrep.I can hold this PR back if it causes any issues in earlier versions.