Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(state-machine): Panic in the case of non-handled non-deferred e… #1464

Open
wants to merge 5 commits into
base: feature-c++-client
Choose a base branch
from
Open

chore(state-machine): Panic in the case of non-handled non-deferred e… #1464

wants to merge 5 commits into from

Commits on Dec 4, 2023

  1. refac(dbus): Wrap the DbusError resource in a smart pointer 

    Just makes it more future proof, as we don't have to remember free it in our
exit paths anylonger.

Signed-off-by: Ole Petter <[email protected]>
    @oleorhagen
    oleorhagen committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    72bcf04 View commit details
    Browse the repository at this point in the history

  2. refac(dbus): Replace all NULL instances with nullptr 

    This just makes this consistent with the rest of our codebase.

Signed-off-by: Ole Petter <[email protected]>
    @oleorhagen
    oleorhagen committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1548f54 View commit details
    Browse the repository at this point in the history

  3. chore: Spelling 'A sync' -> 'Async' 

    Signed-off-by: Ole Petter <[email protected]>
    @oleorhagen
    oleorhagen committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    000e106 View commit details
    Browse the repository at this point in the history

  4. refac(state-machine): Clarify the logic in the RunOne function 

    Simply split out and name the logical parts.

Signed-off-by: Ole Petter <[email protected]>
    @oleorhagen
    oleorhagen committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d21b262 View commit details
    Browse the repository at this point in the history

  5. chore(state-machine): Panic in the case of non-handled non-deferred e… 

    …vents

This adds a sanity check to verify that there are no non-deferred events left in
the event queue after the run_queue has been populated.

If there was, then we would have undefined behaviour in the state-machine, and
as such the best thing we can do in this instance is to panic. This is a serious
logic error in our code, and as such such cause a hard-fault.

Signed-off-by: Ole Petter <[email protected]>
    @oleorhagen
    oleorhagen committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    9cad8e7 View commit details
    Browse the repository at this point in the history