Fix GLES2 demo #590
Open
Fix GLES2 demo #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please explain your changes. |
mode777
commented
Oct 26, 2020
There was a problem hiding this comment.
Sorry, for this pull request - it was kind of an accident trying the automatic pull request feature of vs code. Still some useful stuff in here regarding gles2 (See comments).
Setting vsync on might not be so helpful - I could remove the change in another commit
| @@ -25,7 +25,7 @@ | |||
| #include "nanovg_gl.h" | |||
| #include "nanovg_gl_utils.h" | |||
| #include "demo.h" | |||
| #include "perf.h" | |||
There was a problem hiding this comment.
gles2 does not support API functionality used in perf.h - commented out for now
| @@ -2568,7 +2568,7 @@ int nvgTextGlyphPositions(NVGcontext* ctx, float x, float y, const char* string, | |||
| if (end == NULL) | |||
| end = string + strlen(string); | |||
|
|
|||
| if (string == end) | |||
| if (string >= end) | |||
There was a problem hiding this comment.
Cover the case that start is before end
|
|
||
| glfwSetErrorCallback(errorcb); | ||
|
|
||
| glfwWindowHint(GLFW_CLIENT_API, GLFW_OPENGL_ES_API); | ||
| glfwWindowHint(GLFW_CONTEXT_CREATION_API, GLFW_EGL_CONTEXT_API); |
There was a problem hiding this comment.
Needed by GLFW to use EGL on Windows (e.g. for Angle)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.