Fix fonsTextIterNext when string ends with invalid UTF-8 sequence #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If fonsTextIterNext was called with a string that ended in an invalid UTF-8 sequence then it would erroneously report a success status to the calling function. In my case this cause repeated updates to the font texture atlas which caused major rendering slowdowns. This fixes that by examining the UTF-8 decoder status before returning from the function with a success status code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If fonsTextIterNext was called with a string that ended in an invalid
UTF-8 sequence then it would erroneously report a success status to the
calling function.
In my case this cause repeated updates to the font texture atlas which
caused major rendering slowdowns.
This fixes that by examining the UTF-8 decoder status before returning
from the function with a success status code.