Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make and encoder functions for Point2&3D #65

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

gitbuda
Copy link
Member

@gitbuda gitbuda commented Aug 16, 2024

  • Check the C++ part for additional changes (and make them)
  • Fix the CI process

@gitbuda gitbuda requested review from Ignition and imilinovic August 16, 2024 19:16
@gitbuda gitbuda self-assigned this Aug 16, 2024
@katarinasupe
Copy link

@gitbuda is this maybe related?

@gitbuda
Copy link
Member Author

gitbuda commented Aug 19, 2024

@gitbuda is this maybe related?
Short answer is no, the issue you shared is about procedures; under this PR it's all about the client code.

Long answer: It's similar but different, because I think under memgraph/memgraph#2284 the problem is that enum is not part of the query modules API (mgp, mostly under https://github.com/memgraph/memgraph/blob/master/include/mg_procedure.h, but also under the https://github.com/memgraph/memgraph/blob/master/include/mgp.py). The same applies for spatial data types, we have to extend all procedure APIs.

The relation is that we have to implement support for all data types everywhere 😂 easier said that done, but we'll get there 💪

@gitbuda gitbuda merged commit 316e0cc into master Aug 24, 2024
6 checks passed
@gitbuda gitbuda deleted the add-spatial-make-functions branch August 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants