Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated membrane core dependencies in examples to membrane version 5.3.3 #930

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Updated membrane core dependencies in examples to membrane version 5.3.3 #930

merged 6 commits into from
Mar 14, 2024

Conversation

t-burch
Copy link
Collaborator

@t-burch t-burch commented Mar 5, 2024

No description provided.

@t-burch t-burch requested a review from rrayst March 5, 2024 09:41
rrayst
rrayst requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@rrayst rrayst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do this automatically using ConsistentVersionNumbers?

@t-burch
Copy link
Collaborator Author

t-burch commented Mar 5, 2024

It should already do it, not sure why it does not work

predic8
predic8 previously approved these changes Mar 6, 2024
View reviewed changes
@t-burch t-burch requested a review from predic8 March 6, 2024 12:54
@christiangoerdes christiangoerdes merged commit 0c6f605 into master Mar 14, 2024
2 of 3 checks passed
@christiangoerdes christiangoerdes deleted the dependency-updates branch March 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiangoerdes christiangoerdes christiangoerdes approved these changes

@predic8 predic8 predic8 approved these changes

@rrayst rrayst rrayst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-burch @rrayst @predic8 @christiangoerdes