Add keyAlias functionality to keyStore #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alias selection. - Add method to configure key alias in `SSLContextBuilder`. - Implement unit tests for valid, incorrect, and invalid key aliases using newly created keystore and truststore files.
|
This pull request needs "/ok-to-test" from an authorized committer. |
… to retrieve the common name from X509 certificates and update tests to validate key alias selection. Ensure fallback logic for missing or incorrect key aliases is handled gracefully with appropriate warnings.
Enhance StaticSSLContext to retrieve certificate aliases, ensuring fallback to the first alias when none specified. Add comprehensive tests for KeyStoreUtil methods.
…a KeyStore based on provided parameters. Update tests to validate these functionalities, ensuring correct behavior for alias handling. Refactor existing methods for consistency and clarity.
…ontext' into #1238-keyalias-support-for-ssl-context
|
/ok-to-test |
…e a new KeyStore containing only the specified key and its certificate chain. - Update `StaticSSLContext` to use the filtered KeyStore for initializing the KeyManagerFactory. - Add unit tests for key alias filtering in `KeyStoreUtilTest` and SSL context behavior in `SSLContextTest`. - Include a new truststore for validating second key alias scenarios.
|
Looks good to me |
rrayst
approved these changes
Aug 30, 2024
rrayst
requested changes
Aug 30, 2024
Implement functionality to specify a key alias for the SSL context, enhancing flexibility in managing multiple keys. Update relevant documentation to reflect these changes and ensure consistent usage across the application.
…ontext' into #1238-keyalias-support-for-ssl-context
rrayst
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.