Fix overflow akward implementation

Issue #55
mellowcandle · Jul 18, 2023 · 77f8f45 · 77f8f45
1 parent e05fb0d
commit 77f8f45
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/cmd.c b/src/cmd.c
@@ -180,6 +180,10 @@ static int parse_cmd(char *cmdline)
 			return -1;
 		} else {
 			char result_string[256];
+			if (result > MASK(g_width)) {
+				result &= MASK(g_width);
+				append_to_history("Overflow!", TYPE_OUTPUT_ERROR);
+			}
 			g_val = result;
 
 			if (g_output == CMD_OUTPUT_ALL) {

diff --git a/src/interactive.c b/src/interactive.c
@@ -493,7 +493,7 @@ void process_fields(int ch)
 		wrefresh(fields_win);
 		break;
 	default:
-		LOG("default char\n");
+		LOG("default char: %d\n", ch);
 
 		tmp_field = current_field(form);
 		cur_base = field_userptr(tmp_field);
@@ -651,7 +651,6 @@ int start_interactive(uint64_t start)
 			}
 			break;
 
-
 		case KEY_F(1):
 			unpaint_screen();
 			show_help();

diff --git a/src/main.c b/src/main.c
@@ -226,6 +226,8 @@ int main(int argc, char *argv[])
 		free(expression);
 		if (!g_width)
 			set_width_by_val(val);
+		if (val > MASK(g_width))
+			fprintf(stderr, "%sExpression overflowed!\n", color_red);
 		val &= MASK(g_width);
 		if (!interactive)
 			return print_conversions(val, si);