Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ-718: Combine SENAITE docker images in one repo #19

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Conversation

VaishSiddharth
Copy link
Contributor

Copy link
Contributor

@enyachoke enyachoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to share stuff from the .cfg files instead of having completely different sets of files

@rbuisson rbuisson requested a review from enyachoke December 16, 2024 15:56
.github/workflows/build_sso.yaml Outdated Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have one GA workflow file with two jobs. Also, let's utilize shared workflows.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please can you have a look at the build.yml file and see if all the configuration are okay
cc: @corneliouzbett @enyachoke

@VaishSiddharth VaishSiddharth requested review from corneliouzbett and removed request for corneliouzbett January 2, 2025 06:44
.github/workflows/build_sso.yaml Outdated Show resolved Hide resolved
@VaishSiddharth VaishSiddharth merged commit 621fae4 into main Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants