feat: replace deprecated ioctl with nix (#86) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKRainbow
pushed a commit
to EasyTier/rust-tun
that referenced
this pull request
Aug 6, 2024
* Add send and recv apis similar to Tokio::UdpSocket Tokio supports async api's for UDP socket which does not need `&mut self` pub async fn recv(&self, buf: &mut [u8]) -> Result<usize> pub async fn send(&self, buf: &[u8]) -> Result<usize> This makes it pretty easy to call it concurrently, without adding Arc<Mutex<T>> to UdpSocket. This PR tries to add support for similar apis to tun device. In this commit, only sync version of recv/send apis are added. Async version will be added in further commit. Reference: https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.recv https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.send * Refactor to use STACK_BUF_LEN as const * Add async unix send/recv apis for unix Since unix uses AsyncFd from tokio, it is easier to wait for Ready on AsyncFd and call sync send/recv apis This commit does not take care of windows, which is not as straight-forward as posix variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to replace the deprecated
ioctl(orioctl-sys) with a more actively maintained cratenix.fixed #86 .