Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adapt to Engine API changes for GetPayload and NewPayload methods #5

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: adapt to Engine API changes for GetPayload and NewPayload methods #5

wants to merge 3 commits into from

Conversation

SilasZhr
Copy link
Collaborator

@SilasZhr SilasZhr commented Oct 29, 2024 •
edited
Loading

Changes:

  • replace GetPayloadwith GetMinimizedPayload and replace NewPayload with NewPayloadById
  • temporarily bypass sanity check to avoid processing all txns
  • disabled the feature of spreading unsafe payloads to conductors via gossip, as the op-node can only retrieve incomplete payloads

@Troublor
Copy link
Collaborator

This PR does not work with current develop branch in mega-reth, correct? Let's wait for the streaming PR to be merged in to develop in mega-reth first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangl1996 yangl1996 Awaiting requested review from yangl1996

@yilongli yilongli Awaiting requested review from yilongli

@Troublor Troublor Awaiting requested review from Troublor

@claymega claymega Awaiting requested review from claymega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SilasZhr @Troublor