service.css was updated to modify top menu links
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`service.css` was updated to remove of disable unnecessary links from the top menu to remove the possibility to navigate away from the Talk app: - disable Nextcloud logo, Talk and settings link; - remove "More" and contacts link.
This may be Ferdi specific though. This was the error when packaging the recipe for Ferdi: Could not add your recipe: There were errors in your package.json: Your package.json contains a 'config' object with no 'serviceURL' field. This field should contain the URL of your service. For more information about the package.json file visit https://github.com/getferdi/recipes/blob/master/docs/configuration.md
`service.css` was updated to: - unhide contacts menu; - hide notifications that are not related to Nextcloud Talk; - hide "Dismiss all notifications" as this action would also dismiss hidden notifications. `webview.js` was updated to fix notifications (both direct and indirect) count retrieval.
`webview.js` was updated to get direct notifications count only when notification wrapper has been loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service.csswas updated to remove or disable unnecessary links in the topmenu to remove the possibility to navigate away from the Talk app:
notifications..
webview.jswas updated to fix notifications (both direct and indirect) countretrieval.