Mattermost: fix unreads count #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Unread messages" badge was broken for two reasons. 1. Mattermost introduced a new configurable Sidebar, which broke the selectors used by the recipe. _Note that the legacy sidebar can still be enabled, and may also_ _be displayed by older Mattermost instances. So for compatibility,_ _the legacy selectors are kept._ 2. Direct group messages (direct messages sent to more than one person) weren't counted at all. Now these messages are properly counted as direct messages (because that's how Mattermost UI considers them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Unread messages" badge was broken for two reasons.
Mattermost introduced a new configurable Sidebar, which broke the
selectors used by the recipe.
Note that the legacy sidebar can still be enabled, and may also
be displayed by older Mattermost instances. So for compatibility,
the legacy selectors are kept.
Direct group messages (direct messages sent to more than one person)
weren't counted at all.
Now these messages are properly counted as direct messages (because
that's how Mattermost UI considers them).
Fix #6