Fix broken encodeRunestoneUnsafe function #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
encodeRunestoneUnsafe
is important in itself because whileunsafe
for real time data, it does a job in testing stuff like divisibility, among other conditionals. It can be used, in the future, to test also, by receiving current block, if the rune name is available.It makes me think tho if rather than giving maintenance to
encodeRunestoneUnsafe
if it isnt better to just expose through the library Rune and SpacedRune, and then test the stuff currently being tested onencodeRunestoneUnsafe
inside the contructor of Rune and SpacedRune. This way, you can remove the complexity of havingencodeRunestoneUnsafe
, and can rely completely on unit tests of the classes.DX might suffer a bit, but then again you can just provide some examples in the readme on how to construct a rune from
Rune
orSpacedRune
classes