Skip to content

Commit

Permalink
vma: Add !VVAR condition to vma_entry_can_be_lazy
Browse files Browse the repository at this point in the history
Currently most of the times we don't have problems with VVAR segment and
lazy restore because when VDSO is parked there is an munmap call that
calls UFFDIO_UNREGISTER on the destination address.
But we don't want to enable userfaultfd for VDSO and VVAR at the first
place.
  • Loading branch information
yota9 authored and avagin committed Sep 29, 2023
1 parent 1e4f5fb commit 4f0c07f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions criu/include/vma.h
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ static inline struct vma_area *vma_next(struct vma_area *vma)
static inline bool vma_entry_can_be_lazy(VmaEntry *e)
{
return ((e->flags & MAP_ANONYMOUS) && (e->flags & MAP_PRIVATE) && !(e->flags & MAP_LOCKED) &&
!(vma_entry_is(e, VMA_AREA_VDSO)) && !(vma_entry_is(e, VMA_AREA_VSYSCALL)) &&
!(e->flags & MAP_HUGETLB));
!(vma_entry_is(e, VMA_AREA_VDSO)) && !(vma_entry_is(e, VMA_AREA_VVAR)) &&
!(vma_entry_is(e, VMA_AREA_VSYSCALL)) && !(e->flags & MAP_HUGETLB));
}

#endif /* __CR_VMA_H__ */

0 comments on commit 4f0c07f

Please sign in to comment.