Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items JSON fixes #448

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Items JSON fixes #448

wants to merge 4 commits into from

Conversation

MestreLion
Copy link

Fixes a few minor things in mceditlib/blocktypes/tmp_items.json:

  • Add "Enchanted Golden Apple" displayName for item 322, DV 1
  • Fix maxdamage for Spawn Eggs, better leave it as 0 as DV handling is very complex
  • Remove duplicated maxdamage in Golden Boots

@Kadack
Copy link

Kadack commented Mar 27, 2021

I can't open my world 1.16.3 in mcedit2 and mcedit1 i rinitialised my computer after i can't open any world was created in 1.15 and + idk for 1.14 i can open 1.8 save

An error occurred while opening C:\Users\user\AppData\Roaming.minecraft\saves\tr bedrock
'NoneType' object is not iterable

Traceback (most recent call last):
File "mcedit2\editorapp.py", line 790, in loadFile (self is a MCEditApp)
File "mcedit2\editorsession.py", line 419, in init (self is a EditorSession)
File "mcedit2\editorsession.py", line 724, in setConfiguredBlocks (self is a EditorSession)
File "mcedit2\editorsession.py", line 728, in reloadModels (self is a EditorSession)
File "src\mcedit2\rendering\blockmodels.pyx", line 236, in mcedit2.rendering.blockmodels.BlockModels.init
File "src\mcedit2\rendering\blockmodels.pyx", line 278, in mcedit2.rendering.blockmodels.BlockModels.loadModelParts
TypeError: 'NoneType' object is not iterable

@MestreLion
Copy link
Author

@Kadack , there were major changes in Minecraft 1.13 save format, so many tools, including this mcedit2, are unable to open 1.13+ Worlds. Besides, this project seems dead, not a single update in over 2 years.

Last but not the least, spamming your issue in every single (unrelated) Pull Pequest is considered very bad practice in GitHub. Most projects have an "issues" area where you can report bugs. Unfortunately, this project seems to have disabled bug reporting.

For worlds created in Minecraft 1.13 or newer, you should look for another tool or library. Unfortunately I have no suggestion or recommendation to you. I once wrote a library myself, but it also got outdated since Minecraft 1.15 once again changed its save file format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants