Skip to content

Commit

Permalink
fix: fix catalog inconsistency, disable heartbeat in remote catalog s…
Browse files Browse the repository at this point in the history
…ervice, support multi-frontend in future.
  • Loading branch information
yezizp2012 authored Nov 30, 2021
1 parent 6cb1557 commit 759301f
Showing 1 changed file with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
Expand All @@ -61,7 +60,13 @@ public RemoteCatalogService(MetaClient client) {
this.databaseByName = new ConcurrentHashMap<>();
this.creatingTable = new ConcurrentHashMap<>();
initCatalog();
startHeartbeatSchedule(Executors.newSingleThreadScheduledExecutor());
/*
FIXME: simply stop heartbeat here. There still got an asynchrony inconsistency between create table and
table dropped detection in heartbeat. ReadWrite lock should be introduced here to ensure consistency
which will brings some overhead here. Since heartbeat is only a temporary solution for multi-frontends
deployment, we will fix this when broadcast catalog solution finished development in meta service.
*/
// startHeartbeatSchedule(Executors.newSingleThreadScheduledExecutor());
}

private void startHeartbeatSchedule(ScheduledExecutorService service) {
Expand Down

0 comments on commit 759301f

Please sign in to comment.