Generate pdb files (in release) and provide them along the installer.

maxr-dot-org · Mar 9, 2024 · cb51f21 · cb51f21
1 parent d6da1ff
commit cb51f21
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/.github/workflows/premake5-windows.yml b/.github/workflows/premake5-windows.yml
@@ -72,3 +72,4 @@ jobs:
         path: |
           data/**.exe
           data/**.dll
+          data/**.pdb
diff --git a/.github/workflows/release-windows.yml b/.github/workflows/release-windows.yml
@@ -57,3 +57,9 @@ jobs:
       with:
         name: maxr-installer.exe
         path: mk/win32/installer/maxr-*.exe
+
+    - name: Upload pdb files
+      uses: actions/upload-artifact@v4
+      with:
+        name: maxr.pdb
+        path: data/*.pdb
diff --git a/mk/win32/installer/maxr-installer.nsi b/mk/win32/installer/maxr-installer.nsi
@@ -162,7 +162,7 @@ Section "$(TITLE_Section_Main)" Section_Main
     SetOutPath $INSTDIR
 
     # now install all files
-    File /r "${FILESFOLDER}"
+    File /r /x *.pdb "${FILESFOLDER}"
 SectionEnd
 
 Section "$(TITLE_Section_Start_Menu_Link)" Section_Start_Menu_Link

diff --git a/premake5.lua b/premake5.lua
@@ -88,6 +88,9 @@ end
 		defines { "NDEBUG" }
 		optimize "On"
 
+	filter { "toolset:msc*" }
+		symbols "On" -- pdb even on release
+
 	filter "system:windows"
 		defines { "WIN32" }