Fix some msvc warnings.

maxr-dot-org · Mar 7, 2024 · b60d083 · b60d083
1 parent 0cfca2c
commit b60d083
Show file tree

Hide file tree

Showing 74 changed files with 124 additions and 142 deletions.
diff --git a/premake5.lua b/premake5.lua
@@ -72,12 +72,9 @@ end
 	filter { "action:vs*" }
 		nuget(nugetPackages)
 	filter { "toolset:msc*" }
-		--defines { "USE_CRASH_RPT" }
 		defines { "_CRT_SECURE_NO_WARNINGS" } -- 4996: '$func': This function or variable may be unsafe. Consider using $func2 instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
 		buildoptions { "/Zc:__cplusplus" } -- else __cplusplus would be 199711L
 		disablewarnings {
-			"4100", -- '%var': unreferenced formal parameter
-			"4013", -- '$func' undefined, assuming extern return int
 			"4458", -- declaration of '$var' hides class member
 			"4701", -- potentially uninitialized local variable '$var' used
 			"4703", -- potentially uninitialized local pointer variable '$var' used

diff --git a/src/lib/chatcommand/chatcommandarguments.cpp b/src/lib/chatcommand/chatcommandarguments.cpp
@@ -237,7 +237,7 @@ cChatCommandArgumentServer::cChatCommandArgumentServer (cServer*& serverPointer,
 {}
 
 //------------------------------------------------------------------------------
-size_t cChatCommandArgumentServer::parse (const std::string& command, size_t position)
+size_t cChatCommandArgumentServer::parse (const std::string&, size_t position)
 {
 	value = serverPointer;
 	if (value == nullptr)
@@ -276,7 +276,7 @@ cChatCommandArgumentClient::cChatCommandArgumentClient (const std::shared_ptr<cC
 {}
 
 //------------------------------------------------------------------------------
-size_t cChatCommandArgumentClient::parse (const std::string& command, size_t position)
+size_t cChatCommandArgumentClient::parse (const std::string&, size_t position)
 {
 	if (activeClientPointer == nullptr)
 	{

diff --git a/src/lib/chatcommand/chatcommandparser.cpp b/src/lib/chatcommand/chatcommandparser.cpp
@@ -37,13 +37,13 @@ cChatCommandParser<>::cChatCommandParser (cChatCommand command_) :
 {}
 
 //------------------------------------------------------------------------------
-size_t cChatCommandParser<>::parse (const std::string& command, size_t position) const
+size_t cChatCommandParser<>::parse (const std::string&, size_t position) const
 {
 	return position;
 }
 
 //------------------------------------------------------------------------------
-void cChatCommandParser<>::printArguments (std::ostream& result) const
+void cChatCommandParser<>::printArguments (std::ostream&) const
 {}
 
 //------------------------------------------------------------------------------

diff --git a/src/lib/crashreporter/debug.cpp b/src/lib/crashreporter/debug.cpp
@@ -45,7 +45,7 @@
 # endif
 
 //------------------------------------------------------------------------------
-int CALLBACK CrashCallback (CR_CRASH_CALLBACK_INFO* pInfo)
+int CALLBACK CrashCallback (CR_CRASH_CALLBACK_INFO*)
 {
 	// The application has crashed!
 	if (cVideo::buffer)

diff --git a/src/lib/game/connectionmanager.cpp b/src/lib/game/connectionmanager.cpp
@@ -57,7 +57,7 @@ class cHandshakeTimeout
 
 private:
 	//--------------------------------------------------------------------------
-	static uint32_t callback (uint32_t intervall, void* arg)
+	static uint32_t callback (uint32_t, void* arg)
 	{
 		cHandshakeTimeout* thisPtr = reinterpret_cast<cHandshakeTimeout*> (arg);
 		thisPtr->connectionManager->handshakeTimeoutCallback (*thisPtr);

diff --git a/src/lib/game/data/model.cpp b/src/lib/game/data/model.cpp
@@ -444,7 +444,7 @@ cMoveJob* cModel::addMoveJob (cVehicle& vehicle, const std::forward_list<cPositi
 			currentMoveJob->removeVehicle();
 		}
 	}
-	auto moveJob = std::make_unique<cMoveJob> (path, vehicle, *this);
+	auto moveJob = std::make_unique<cMoveJob> (path, vehicle);
 	vehicle.setMoveJob (moveJob.get());
 
 	moveJobs.push_back (std::move (moveJob));

diff --git a/src/lib/game/data/savegame.cpp b/src/lib/game/data/savegame.cpp
@@ -71,7 +71,7 @@ namespace
 	}
 
 	//--------------------------------------------------------------------------
-	void writeHeader (nlohmann::json& json, int slot, const std::string& saveName, const cModel& model)
+	void writeHeader (nlohmann::json& json, const std::string& saveName, const cModel& model)
 	{
 		//init document
 		json["version"] = SAVE_FORMAT_VERSION;
@@ -97,7 +97,7 @@ namespace
 void cSavegame::save (const cModel& model, int slot, const std::string& saveName) const
 {
 	nlohmann::json json;
-	writeHeader (json, slot, saveName, model);
+	writeHeader (json, saveName, model);
 
 	cJsonArchiveOut archive (json);
 	archive << NVP (model);

diff --git a/src/lib/game/logic/action/actionendturn.cpp b/src/lib/game/logic/action/actionendturn.cpp
@@ -26,7 +26,7 @@ cActionEndTurn::cActionEndTurn()
 {}
 
 //------------------------------------------------------------------------------
-cActionEndTurn::cActionEndTurn (cBinaryArchiveIn& archive)
+cActionEndTurn::cActionEndTurn (cBinaryArchiveIn&)
 {}
 
 //------------------------------------------------------------------------------

diff --git a/src/lib/game/logic/client.cpp b/src/lib/game/logic/client.cpp
@@ -146,12 +146,13 @@ void cClient::sendSyncMessage (unsigned int gameTime, bool crcOK, unsigned int t
 }
 
 //------------------------------------------------------------------------------
-void cClient::runClientJobs (const cModel& model)
+void cClient::runClientJobs()
 {
 	// run surveyor AI
 	handleSurveyorMoveJobs();
 }
 
+//------------------------------------------------------------------------------
 void cClient::handleNetMessages()
 {
 	std::unique_ptr<cNetMessage> message;

diff --git a/src/lib/game/logic/client.h b/src/lib/game/logic/client.h
@@ -123,7 +123,7 @@ class cClient : public INetMessageReceiver
 
 	void handleNetMessages();
 
-	void runClientJobs (const cModel&);
+	void runClientJobs();
 
 	const std::shared_ptr<cGameTimerClient>& getGameTimer() const { return gameTimer; }
 

diff --git a/src/lib/game/logic/gametimer.cpp b/src/lib/game/logic/gametimer.cpp
@@ -264,7 +264,7 @@ void cGameTimerClient::run (cClient& client, cModel& model)
 		if (syncMessageReceived)
 		{
 			model.advanceGameTime();
-			client.runClientJobs (model);
+			client.runClientJobs();
 
 			//check crc
 			localChecksum = model.getChecksum();

diff --git a/src/lib/game/logic/movejob.cpp b/src/lib/game/logic/movejob.cpp
@@ -89,7 +89,7 @@ cMoveJob::cMoveJob() :
 {}
 
 //------------------------------------------------------------------------------
-cMoveJob::cMoveJob (const std::forward_list<cPosition>& path, cVehicle& vehicle, cModel& model) :
+cMoveJob::cMoveJob (const std::forward_list<cPosition>& path, cVehicle& vehicle) :
 	vehicleId (vehicle.getId()),
 	path (path),
 	state (eMoveJobState::Waiting),

diff --git a/src/lib/game/logic/movejob.h b/src/lib/game/logic/movejob.h
@@ -42,7 +42,7 @@ class cMoveJob
 {
 public:
 	cMoveJob();
-	cMoveJob (const std::forward_list<cPosition>& path, cVehicle&, cModel&);
+	cMoveJob (const std::forward_list<cPosition>& path, cVehicle&);
 	/**
 	* gets the list of position that make up the path. First element is the position,
 	* the unit will drive to when starting the next movement step.

diff --git a/src/lib/game/logic/server.cpp b/src/lib/game/logic/server.cpp
@@ -134,8 +134,9 @@ void cServer::loadGameState (int saveGameNumber)
 	gameTimer.setPlayerNumbers (model.getPlayerList());
 }
 //------------------------------------------------------------------------------
-void cServer::sendGuiInfoToClients (int saveGameNumber, int playerNr /*= -1*/)
+void cServer::sendGuiInfoToClients (int saveGameNumber, [[maybe_unused]] int playerNr /*= -1*/)
 {
+	// TODO: handle playerNr
 	try
 	{
 		cSavegame savegame;

diff --git a/src/lib/game/protocol/lobbymessage.cpp b/src/lib/game/protocol/lobbymessage.cpp
@@ -261,7 +261,7 @@ cMuMsgAskToFinishLobby::cMuMsgAskToFinishLobby()
 {}
 
 //------------------------------------------------------------------------------
-cMuMsgAskToFinishLobby::cMuMsgAskToFinishLobby (cBinaryArchiveIn& archive)
+cMuMsgAskToFinishLobby::cMuMsgAskToFinishLobby (cBinaryArchiveIn&)
 {}
 
 //------------------------------------------------------------------------------
@@ -287,7 +287,7 @@ void cMuMsgCannotEndLobby::serialize (cBinaryArchiveOut& archive)
 cMuMsgDisconnectNotInSavedGame::cMuMsgDisconnectNotInSavedGame()
 {}
 //------------------------------------------------------------------------------
-cMuMsgDisconnectNotInSavedGame::cMuMsgDisconnectNotInSavedGame (cBinaryArchiveIn& archive)
+cMuMsgDisconnectNotInSavedGame::cMuMsgDisconnectNotInSavedGame (cBinaryArchiveIn&)
 {}
 
 //------------------------------------------------------------------------------
@@ -373,23 +373,23 @@ void cMuMsgLandingState::serialize (cBinaryArchiveOut& archive)
 cMuMsgStartGame::cMuMsgStartGame()
 {}
 //------------------------------------------------------------------------------
-cMuMsgStartGame::cMuMsgStartGame (cBinaryArchiveIn& archive)
+cMuMsgStartGame::cMuMsgStartGame (cBinaryArchiveIn&)
 {}
 
 //------------------------------------------------------------------------------
 //------------------------------------------------------------------------------
 cMuMsgPlayerAbortedGamePreparations::cMuMsgPlayerAbortedGamePreparations()
 {}
 //------------------------------------------------------------------------------
-cMuMsgPlayerAbortedGamePreparations::cMuMsgPlayerAbortedGamePreparations (cBinaryArchiveIn& archive)
+cMuMsgPlayerAbortedGamePreparations::cMuMsgPlayerAbortedGamePreparations (cBinaryArchiveIn&)
 {}
 
 //------------------------------------------------------------------------------
 //------------------------------------------------------------------------------
 cMuMsgFinishedMapDownload::cMuMsgFinishedMapDownload()
 {}
 //------------------------------------------------------------------------------
-cMuMsgFinishedMapDownload::cMuMsgFinishedMapDownload (cBinaryArchiveIn& archive)
+cMuMsgFinishedMapDownload::cMuMsgFinishedMapDownload (cBinaryArchiveIn&)
 {}
 
 //------------------------------------------------------------------------------
@@ -473,7 +473,7 @@ void cMuMsgMapDownloadData::serialize (cBinaryArchiveOut& archive)
 cMuMsgCanceledMapDownload::cMuMsgCanceledMapDownload()
 {}
 //------------------------------------------------------------------------------
-cMuMsgCanceledMapDownload::cMuMsgCanceledMapDownload (cBinaryArchiveIn& archive)
+cMuMsgCanceledMapDownload::cMuMsgCanceledMapDownload (cBinaryArchiveIn&)
 {}
 
 //------------------------------------------------------------------------------

diff --git a/src/lib/game/protocol/netmessage.h b/src/lib/game/protocol/netmessage.h
@@ -689,7 +689,7 @@ class cNetMessageWantRejoinGame : public cNetMessageT<eNetMessageType::WANT_REJO
 {
 public:
 	cNetMessageWantRejoinGame() = default;
-	explicit cNetMessageWantRejoinGame (cBinaryArchiveIn& archive)
+	explicit cNetMessageWantRejoinGame (cBinaryArchiveIn&)
 	{}
 };
 

diff --git a/src/lib/game/startup/lobbyclient.cpp b/src/lib/game/startup/lobbyclient.cpp
@@ -384,7 +384,7 @@ void cLobbyClient::handleNetMessage_TCP_CONNECT_FAILED (const cNetMessageTcpConn
 }
 
 //------------------------------------------------------------------------------
-void cLobbyClient::handleNetMessage_TCP_CLOSE (const cNetMessageTcpClose& message)
+void cLobbyClient::handleNetMessage_TCP_CLOSE (const cNetMessageTcpClose&)
 {
 	localPlayer.setReady (false);
 	localPlayer.setNr (-1);
@@ -529,7 +529,7 @@ void cLobbyClient::handleNetMessage_MU_MSG_LANDING_STATE (const cMuMsgLandingSta
 }
 
 //------------------------------------------------------------------------------
-void cLobbyClient::handleNetMessage_MU_MSG_START_GAME (const cMuMsgStartGame& message)
+void cLobbyClient::handleNetMessage_MU_MSG_START_GAME (const cMuMsgStartGame&)
 {
 	client = std::make_shared<cClient> (connectionManager);
 	client->setPlayers (players, localPlayer.getNr());

diff --git a/src/ui/graphical/game/control/gameguicontroller.cpp b/src/ui/graphical/game/control/gameguicontroller.cpp
@@ -1130,7 +1130,7 @@ void cGameGuiController::connectReportSources (cClient& client)
 	playerGameGuiStates[player.getId()].reports = std::make_shared<std::vector<std::unique_ptr<cSavedReport>>>();
 
 	//report message received from server
-	allClientsSignalConnectionManager.connect (client.reportMessageReceived, [this] (int fromPlayerNr, std::unique_ptr<cSavedReport>& report, int toPlayerNr) {
+	allClientsSignalConnectionManager.connect (client.reportMessageReceived, [this] (int, std::unique_ptr<cSavedReport>& report, int toPlayerNr) {
 		addSavedReport (std::move (report), toPlayerNr);
 	});
 
@@ -1286,7 +1286,7 @@ void cGameGuiController::showFilesWindow()
 			gameGui->exit();
 		});
 	});
-	loadSaveWindow->load.connect ([this, loadSaveWindow] (const cSaveGameInfo& saveInfo) {
+	loadSaveWindow->load.connect ([this, loadSaveWindow] (const cSaveGameInfo&) {
 		// loading games while game is running is not yet implemented
 		application.show (std::make_shared<cDialogOk> (lngPack.i18n ("Error_Messages~INFO_Not_Implemented")));
 	});
@@ -1478,7 +1478,7 @@ void cGameGuiController::showStorageWindow (const cUnit& unit)
 		}
 		else
 		{
-			gameGui->getGameMap().startActivateVehicle (unit, index);
+			gameGui->getGameMap().startActivateVehicle (index);
 		}
 		storageWindow->close();
 	});

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionactivatefinished.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionactivatefinished.cpp
@@ -23,7 +23,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionActivateFinished::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionActivateFinished::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView&, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedBuilding = unitSelection.getSelectedBuilding();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionactivateloaded.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionactivateloaded.cpp
@@ -28,7 +28,7 @@ cMouseActionActivateLoaded::cMouseActionActivateLoaded (int vehicleToActivateInd
 {}
 
 //------------------------------------------------------------------------------
-bool cMouseActionActivateLoaded::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionActivateLoaded::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView&, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedUnit = unitSelection.getSelectedUnit();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionattack.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionattack.cpp
@@ -25,7 +25,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionAttack::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionAttack::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView&, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
 	const auto selectedBuilding = unitSelection.getSelectedBuilding();

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactiondisable.cpp b/src/ui/graphical/game/control/mouseaction/mouseactiondisable.cpp
@@ -27,7 +27,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionDisable::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionDisable::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionenter.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionenter.cpp
@@ -28,7 +28,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionEnter::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionEnter::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionhelp.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionhelp.cpp
@@ -27,7 +27,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionHelp::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionHelp::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection&, bool /* changeAllowed */) const /* override */
 {
 	const auto& field = map.getField (mapPosition);
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionload.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionload.cpp
@@ -24,7 +24,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionLoad::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionLoad::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView&, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedUnit = unitSelection.getSelectedUnit();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionmove.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionmove.cpp
@@ -30,7 +30,7 @@ cMouseActionMove::cMouseActionMove (eStart start) :
 {}
 
 //------------------------------------------------------------------------------
-bool cMouseActionMove::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionMove::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView&, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionrepair.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionrepair.cpp
@@ -27,7 +27,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionRepair::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionRepair::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionselect.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionselect.cpp
@@ -29,7 +29,7 @@
 #include "utility/listhelpers.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionSelect::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionSelect::executeLeftClick (cGameMapWidget&, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
 	const auto selectedBuilding = unitSelection.getSelectedBuilding();

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionselectbuildpathdestination.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionselectbuildpathdestination.cpp
@@ -24,7 +24,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionSelectBuildPathDestination::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionSelectBuildPathDestination::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView&, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionselectbuildposition.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionselectbuildposition.cpp
@@ -30,7 +30,7 @@ cMouseActionSelectBuildPosition::cMouseActionSelectBuildPosition (sID buildId_,
 {}
 
 //------------------------------------------------------------------------------
-bool cMouseActionSelectBuildPosition::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionSelectBuildPosition::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView&, const cPosition&, cUnitSelection& unitSelection, bool /* changeAllowed */) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
 

diff --git a/src/ui/graphical/game/control/mouseaction/mouseactionsteal.cpp b/src/ui/graphical/game/control/mouseaction/mouseactionsteal.cpp
@@ -26,7 +26,7 @@
 #include "ui/graphical/game/widgets/gamemapwidget.h"
 
 //------------------------------------------------------------------------------
-bool cMouseActionSteal::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool changeAllowed) const
+bool cMouseActionSteal::executeLeftClick (cGameMapWidget& gameMapWidget, const cMapView& map, const cPosition& mapPosition, cUnitSelection& unitSelection, bool /*  changeAllowed */) const /* override */
 {
 	const auto selectedVehicle = unitSelection.getSelectedVehicle();
-Original file line number
+Diff line change
@@ Expand Up @@
     {
     public:
     	cNetMessageWantRejoinGame() = default;
-    	explicit cNetMessageWantRejoinGame (cBinaryArchiveIn& archive)
+    	explicit cNetMessageWantRejoinGame (cBinaryArchiveIn&)
     	{}
     };
@@ Expand Down @@