Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product-Team-Conversion #247

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Conversation

RitaOC
Copy link
Contributor

@RitaOC RitaOC commented Oct 31, 2024

No description provided.

@RitaOC
Copy link
Contributor Author

RitaOC commented Oct 31, 2024

Kindly review
@RCheesley @fakela @favour-chibueze
Issue: #227

RCheesley
RCheesley previously approved these changes Nov 4, 2024
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RitaOC I've moved a few things around to better situate them. Teams already had their own section, so I moved the Product Team overview there.

I found an issue with your mautic_slack.py where you've introduced a typo, which was breaking the build - please be sure to to use the make html command locally to make sure that everything still builds before submitting.

I reverted a change to the .gitpod.yml which I think was probably made in error - be careful staging all files for commit as sometimes things like this can creep in. It's better to stage the files individually, if you can.

I've also moved the RFP page into a policies folder, which I think is a better place for it to live, and fixed some vale issues. Should be good to go.

RCheesley
RCheesley previously approved these changes Nov 4, 2024
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a bunch more things to fix - should be OK now.

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for all the hard work here!

One small issue which is breaking the build, where we need to fix the email address link by adding a mailto: in front of it, then we should be good to go! 🚀

Co-authored-by: Ruth Cheesley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants