Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google summer of code #239

Merged
merged 23 commits into from
Oct 28, 2024
Merged

Google summer of code #239

merged 23 commits into from
Oct 28, 2024

Conversation

Iqmaa
Copy link
Contributor

@Iqmaa Iqmaa commented Oct 21, 2024

Fixes #228 subsection Google Summer of Code. Converted the Google summer of Code page to RST following the given guidelines

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this so far @Iqmaa - I have made some suggestions for you to fix the reported Vale errors.

docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
@Iqmaa Iqmaa requested a review from RCheesley October 22, 2024 09:34
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes suggested by Vale - shout if you need any help!

docs/contributing/google_summer_of_code.rst Outdated Show resolved Hide resolved
grammar correction

Co-authored-by: Ruth Cheesley <[email protected]>
@Iqmaa
Copy link
Contributor Author

Iqmaa commented Oct 25, 2024

Just some small changes suggested by Vale - shout if you need any help!

Done,
Thanks @RCheesley !

@Iqmaa Iqmaa requested a review from RCheesley October 25, 2024 14:16
RCheesley
RCheesley previously approved these changes Oct 28, 2024
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Iqmaa - this is good to go 🚀

@RCheesley
Copy link
Member

This is good to merge now, the other issues causing it to fail are due to #244.

@RCheesley RCheesley merged commit a957c2c into mautic:main Oct 28, 2024
1 of 2 checks passed
Copy link

holopin-bot bot commented Oct 28, 2024

Congratulations @Iqmaa, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm2t3hr4f333050ci9ih9kwsba

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Contributing to Mautic section to RST [multiple sub-issues]
2 participants