Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vtsls globalPlugins for vue/typescript-plugin #750

Merged
merged 1 commit into from
May 30, 2024

Conversation

heavenshell
Copy link
Contributor

@heavenshell heavenshell commented May 27, 2024

Add @vue/typescript-plugin to globalPlugin.

ref https://github.com/yioneko/vtsls/blob/bd2df5a2d45cbc087e4fe285ec7c7396fd96e9cf/packages/service/configuration.schema.json#L1115C6-L1144

@tsukkee
It would be very grateful if you could confirm this PR can use with @vue/typescript-plugin 🙏

ref: #728

@tsukkee
Copy link
Contributor

tsukkee commented May 30, 2024

@heavenshell Sorry for my late reply.
I tried to this PR and found volar-server's setting should be also updated.
Please check heavenshell#1 .
With this PR I confirm volar-server works fine with vtsls!

@mattn mattn merged commit 195fa71 into mattn:master May 30, 2024
14 checks passed
@mattn
Copy link
Owner

mattn commented May 30, 2024

Thanks!

@tsukkee
Copy link
Contributor

tsukkee commented May 30, 2024

Oh, merged! 😅
I'll close heavenshell#1 and create new PR directly to mattn:master.

Sorry, I found my change is also picked. Thank you very much!

@heavenshell heavenshell deleted the topic/vtsls-vue branch May 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants