Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript.tsx to settings.json #636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amadeus
Copy link
Contributor

@amadeus amadeus commented Nov 4, 2022

I was wondering why typescript.tsx file format was not working, and eventually realized it needed to be reflected in settings.json.

Basically I've duplicated what is there for typescriptreact

@amadeus
Copy link
Contributor Author

amadeus commented Nov 14, 2022

Bump on this? 😬

@@ -1575,6 +1575,46 @@
"requires": []
}
],
"typescript.tsx": [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, This name does not work.

Copy link
Contributor Author

@amadeus amadeus Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this convention for years with my own typescript plugin and it works fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants