Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golangci to v1.61.0 #205

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Update golangci to v1.61.0 #205

merged 3 commits into from
Nov 4, 2024

Conversation

wetneb
Copy link
Contributor

@wetneb wetneb commented Jul 8, 2024 •
edited
Loading

Summary

Update golangci from v1.51.1 to v1.59.1 v1.61.0

Ticket Link

Fixes #204.

@mattermost-build
Copy link
Contributor

Hello @wetneb,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei self-requested a review July 20, 2024 05:44
hanzei
hanzei approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

golangci now returns a warning:

level=warning msg="[config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`."

Would you be open to also fixing the warning as part of this PR?

@hanzei hanzei added 2: Dev Review Requires review by a core committer and removed Lifecycle/1:stale labels Jul 24, 2024
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei
Copy link
Contributor

hanzei commented Aug 12, 2024

@Kshitij-Katiyar Gentle reminder to review the PR

@wetneb wetneb changed the title Update golangci to v1.59.1 Update golangci to v1.61.0 Oct 11, 2024
@wetneb
Copy link
Contributor Author

wetneb commented Oct 11, 2024

I've bumped the version to v1.61.0 as a way to generate activity on this PR so as to increase the chances of getting it merged at some point :)

@hanzei hanzei requested a review from wiggin77 October 13, 2024 05:18
@hanzei
Copy link
Contributor

hanzei commented Oct 13, 2024

@wiggin77 Can you please take a look?

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei requested a review from wiggin77 November 4, 2024 07:54
@wiggin77 wiggin77 removed 2: Dev Review Requires review by a core committer Lifecycle/1:stale labels Nov 4, 2024
@wiggin77 wiggin77 merged commit 032ae1f into mattermost:master Nov 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@Kshitij-Katiyar Kshitij-Katiyar Awaiting requested review from Kshitij-Katiyar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

golangci-lint fails
4 participants
@wetneb @mattermost-build @hanzei @wiggin77