Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AWS bundle validation errors #477

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Aug 9, 2023

Summary

This should make it easier to dev to figure out why the bundle is wrongly built.

Ticket Link

https://community.mattermost.com/core/pl/c6nsturm5386dr97z8ypfp96ia

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Aug 9, 2023
@hanzei hanzei added this to the v1.3.0 milestone Aug 9, 2023
@hanzei hanzei requested a review from mickmister August 9, 2023 09:06
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 16, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (cdd5b63) 20.13% compared to head (747f3d0) 20.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   20.13%   20.13%           
=======================================
  Files          80       80           
  Lines        6605     6605           
=======================================
  Hits         1330     1330           
  Misses       5143     5143           
  Partials      132      132           
Files Changed Coverage Δ
upstream/upaws/provision_data.go 60.54% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanzei hanzei merged commit b235e01 into master Aug 16, 2023
7 checks passed
@hanzei hanzei deleted the improve-aws-bundle-validation branch August 16, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants