Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configs): Set correct values in genesis.yaml and sepolia.yaml configs after v25 upgrade #3296

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

sanekmelnikov
Copy link
Collaborator

@sanekmelnikov sanekmelnikov commented Nov 15, 2024

What ❔

This PR:

  • updates the values in genesis.yaml and sepolia.yaml to match what's actually on a chain
  • makes zkstack_cli to compile system contracts with hardhat (just until the next upgrade) instead of forge so that CI can pass

Why ❔

Values for genesisBatchHash and genesisBatchCommitment emitted in NewChainCreationParams for v25 protocol upgrade are incorrect.
That causes problems with genesis and basically making registration of new chains impossible on v25.
Additionally, NewChainCreationParams has to be updated manually.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@sanekmelnikov sanekmelnikov marked this pull request as draft November 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants