Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zkstack): Move containers, explorer and portal commands into ecosystem command #3286

Open
wants to merge 5 commits into
base: matias/refactor-chain-commands
Choose a base branch
from
Open

feat(zkstack): Move containers, explorer and portal commands into ecosystem command #3286

wants to merge 5 commits into from

Conversation

matias-gonz
Copy link
Collaborator

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@matias-gonz matias-gonz requested a review from a team as a code owner November 15, 2024 00:19
@matias-gonz matias-gonz changed the base branch from main to matias/refactor-chain-commands November 15, 2024 00:19
@matias-gonz matias-gonz changed the title feat(zkstack): Move containers command into ecosystem command feat(zkstack): Move containers and explorer commands into ecosystem command Nov 15, 2024
@matias-gonz matias-gonz changed the title feat(zkstack): Move containers and explorer commands into ecosystem command feat(zkstack): Move containers, explorer and portal commands into ecosystem command Nov 15, 2024
Deniallugo
Deniallugo reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@Deniallugo Deniallugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep all of them as is now.
We could slightly refactor it and make it available for both ecosystem and chain

docs/guides/launch.md
@@ -33,7 +33,7 @@ To completely reset the dev environment:
- Repeat the setup procedure above

```bash
zkstack containers
zkstack ecosystem containers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep it separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo left review comments

@yorik yorik Awaiting requested review from yorik yorik was automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 was automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh was automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere was automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet was automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 was automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa was automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matias-gonz @Deniallugo