feat(pruning): Record L1 batch root hash in pruning logs #3266

slowli · 2024-11-12T16:06:39Z

What ❔

Records root hashes of the last hard-pruned L1 batch in pruning logs.

This allows to check tree integrity after recovery after pruning.

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zkstack dev fmt and zkstack dev lint.

slowli · 2024-11-12T18:36:25Z

core/lib/dal/src/pruning_dal/mod.rs

@@ -137,6 +188,7 @@ impl PruningDal<'_, '_> {
        Ok(())
    }

+    /// Does not insert pruning logs; the caller is responsible to do this!


Subjectively, this change makes sense since the data flow becomes quite complicated otherwise (there are 2 sources of state root hashes). WDYT?

slowli added 5 commits November 12, 2024 15:09

Sketch state root hash field in pruning logs

1995f21

Record batch root hashes in hard pruning logs

299ba3d

Change hard_prune_batches_range semantics

5c60134

Update hard pruning uses

551d6c6

Test detecting root hash mismatch after pruning

3ac067b

slowli commented Nov 12, 2024

View reviewed changes

slowli marked this pull request as ready for review November 12, 2024 18:37

slowli requested review from perekopskiy, tomg10 and RomanBrodetski November 12, 2024 18:37