Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: use errors.New() which has no param instead of fmt.Errorf() #47

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

yasyzb
Copy link

@yasyzb yasyzb commented Mar 2, 2024

use errors.New() which has no param instead of fmt.Errorf()

@haraldh
Copy link
Contributor

haraldh commented Mar 7, 2024

oh, please sign your commits (after setting up the keys in github)

Copy link
Contributor

@haraldh haraldh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the commit and repush --force

@yasyzb yasyzb requested a review from haraldh March 8, 2024 23:09
@yasyzb yasyzb force-pushed the replace-errorf branch 3 times, most recently from 72b75f1 to 0354705 Compare March 8, 2024 23:34
@yasyzb
Copy link
Author

yasyzb commented Mar 9, 2024

Please sign the commit and repush --force

Thank you, I have sign commit and repushed, and my commit shows Verified.

@haraldh
Copy link
Contributor

haraldh commented Mar 9, 2024

please rebase onto current origin/main.. no need for merge commits

@yasyzb
Copy link
Author

yasyzb commented Mar 10, 2024

please rebase onto current origin/main.. no need for merge commits

thank you, I have rebased main.

@haraldh haraldh merged commit aec55a2 into matter-labs:main Mar 13, 2024
5 checks passed
@haraldh
Copy link
Contributor

haraldh commented Mar 13, 2024

Thank you!

@yasyzb yasyzb deleted the replace-errorf branch March 14, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants