Give clients avatar URLs for rooms #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 18, 2023 10:36
- Print it out in red so you can spot it easily in a long test log - Pretty print the response json, because life's too short to train your brain to be a JSON parser.
Useful for debugging a test.
Expose this on CSAPI for tests to use too. Also update SlidingSyncUntilMembership to check the membership only. Otherwise it would try to match an avatar. In 99% of cases this would be fine, but things like per-room avatars (or indeed per-room displaynames) would screw this up.
Otherwise you end up with two slices that share ownership of the same data but don't coordinate between one another, see e.g. https://go.dev/play/p/uk3o652Tvye
DMRobertson
force-pushed
the
dmr/avatars2
branch
from
b7c225a
to
a02a559
Compare
kegsay
approved these changes
Jul 18, 2023
kegsay
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to the MSC change matrix-org/matrix-spec-proposals@50ae2c8...912621b.
Supersedes #203.
Closes #166.
Includes opinionated changes to the test helpers.
Sticky bits:
I have chosen to deliberately ignore changes to the DM flag. In fact, I don't think CalculateAvatar even reads the DM flag. I expect this will be good enough for a first pass.
Strongly recommend reviewing commit-by-commit.