Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SYNCV3_MAX_DB_CONN: use it in e2e tests #201

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Add SYNCV3_MAX_DB_CONN: use it in e2e tests #201

merged 6 commits into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. Add SYNCV3_MAX_DB_CONN: use it in e2e tests 

    This is designed to catch a class of SQL transaction bugs where
we BEGIN a transaction and then forget to use that `txn` var, and
do other things on `sql.DB` which will use a different connection.

By testing with max conns = 1 this will deadlock. We also test with
max conns = 2 to try to catch more pernicious failure modes. Using
max conns = 1 effectively serialises access to the database, but
some bugs may only be apparent when there is some limited amount
of concurrency available e.g mid-processing this event, do X. With
max conns = 1 we cannot test this, which is why we also test with
max conns = 2.
    @kegsay
    kegsay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8be0984 View commit details
    Browse the repository at this point in the history

  2. Set healthcheck retries for synapse too now as we start lots of them

    @kegsay
    kegsay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    37dcd91 View commit details
    Browse the repository at this point in the history

  3. Actually honour max conns globally, not per storage struct

    @kegsay
    kegsay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c47665f View commit details
    Browse the repository at this point in the history

  4. Log calculated values for sanity

    @kegsay
    kegsay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ea805f7 View commit details
    Browse the repository at this point in the history

  5. Test double transact

    @kegsay
    kegsay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    2e92828 View commit details
    Browse the repository at this point in the history

  6. Revert "Test double transact" 

    This reverts commit 2e92828.
    @kegsay
    kegsay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    0fa136f View commit details
    Browse the repository at this point in the history