If there's no updates, don't insert anything

matrix-org · May 17, 2024 · 5028f93 · 5028f93
1 parent fcd9b49
commit 5028f93
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/state/migrations/20240517104423_device_list_table.go b/state/migrations/20240517104423_device_list_table.go
@@ -122,6 +122,9 @@ func upDeviceListTable(ctx context.Context, tx *sql.Tx) error {
 				Bucket:       state.BucketSent,
 			})
 		}
+		if len(deviceListRows) == 0 {
+			continue
+		}
 		chunks := sqlutil.Chunkify(5, state.MaxPostgresParameters, state.DeviceListChunker(deviceListRows))
 		for _, chunk := range chunks {
 			var placeholders []string
@@ -143,8 +146,6 @@ func upDeviceListTable(ctx context.Context, tx *sql.Tx) error {
 			)
 			_, err = tx.ExecContext(ctx, query, vals...)
 			if err != nil {
-				fmt.Println(query)
-				fmt.Println(vals...)
 				return fmt.Errorf("failed to bulk insert: %s", err)
 			}
 		}