Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repository instructions #2155
base: main
Are you sure you want to change the base?
Update repository instructions #2155
Changes from all commits
66ea2ed
236f61f
4c34102
e34e513
2fe1190
47cbe60
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about licenses that are not on that list? Every once in a while I encounter those. Draupnir had that too for quite a while. Should just the name be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm that's a very good question. How often did you encounter those?
I mostly want to enforce the SPDX identifier rules to have clean data and keep the door open to 🌈 hypothetical future automation 🌈 but that might be a case of premature optimisation.
I guess we could allow the license name in full text if it doesn't have a SPDX identifier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encountered so far only the draupnir one but I was wondering about the national stuff like eu or german ones. Though I have to check if they maybe have ids on that list. Will check later or tomorrow