Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2716: Incrementally importing history into existing rooms #2716

Open
wants to merge 69 commits into
base: old_master
Choose a base branch
from
Open

MSC2716: Incrementally importing history into existing rooms #2716

wants to merge 69 commits into from

Commits on Aug 4, 2020

  1. MSC2716: Incrementally importing history into existing rooms 

    A proposal for letting ASes specify event parents and timestamps when
submitting events, letting them much more effectively insert past
conversation history.

cc @tulir for feedback, as the main consumer of the ?ts= API today...
    @ara4n
    ara4n committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    8c8d5e3 View commit details
    Browse the repository at this point in the history

  2. note that we don't solve lazyloading history from ASes

    @ara4n
    ara4n committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    3a03172 View commit details
    Browse the repository at this point in the history

  3. add another alternative

    @ara4n
    ara4n committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    5e6b7b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. s/parent/prev_event/ for consistency with SS API

    @ara4n
    ara4n authored Aug 11, 2020
    Configuration menu
    Copy the full SHA
    9451439 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Add initial draft of alternative batch sending historical messages 

    Copied from #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    8668e3a View commit details
    Browse the repository at this point in the history

  2. Update with chunk events

    @MadLittleMods
    MadLittleMods committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    d40f3b9 View commit details
    Browse the repository at this point in the history

  3. Add note about adding m.historical

    @MadLittleMods
    MadLittleMods committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    5854ca2 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Only connect the base insertion event to the specified prev_event

    @MadLittleMods
    MadLittleMods committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    b766be5 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2021

  1. Start of consolidation and adding more clear information

    @MadLittleMods
    MadLittleMods committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    b448452 View commit details
    Browse the repository at this point in the history

  2. Wrap lines

    @MadLittleMods
    MadLittleMods committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    8a4d136 View commit details
    Browse the repository at this point in the history

  3. Add remaining alternatives

    @MadLittleMods
    MadLittleMods committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    92f87ed View commit details
    Browse the repository at this point in the history

  4. Correct stable endpoint location

    @MadLittleMods
    MadLittleMods committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    bb44a63 View commit details
    Browse the repository at this point in the history

  5. Reading pass

    @MadLittleMods
    MadLittleMods committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    3367f56 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Fix casing typo 

    Co-authored-by: witchent <[email protected]>
    @MadLittleMods @witchent
    MadLittleMods and witchent authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    a4c474e View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Split out meta MSC2716 events into their own fields 

    Incorporate feedback from:

 - #2716 (comment)
 - #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    9df8b6e View commit details
    Browse the repository at this point in the history

  2. Remove outdated comment on current iteration of spec 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    b3b7903 View commit details
    Browse the repository at this point in the history

  3. Use more obvious query param name 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    38bebb1 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Rename from chunks to batches 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    7df80fe View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Add graph to show how historical state plays into the DAG

    @MadLittleMods
    MadLittleMods committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3f28588 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Add server detection support

    @MadLittleMods
    MadLittleMods committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    80e68bc View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Prefer empty prev_events=[] over fake prev_events 

    See matrix-org/synapse#11114
    @MadLittleMods
    MadLittleMods committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    1678282 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. GitHub now supports mermaid natively 

    See https://github.blog/2022-02-14-include-diagrams-markdown-files-mermaid/
    @MadLittleMods
    MadLittleMods committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    c6a60b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Incorporate in feedback

    @MadLittleMods
    MadLittleMods committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    65e5f7b View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Fix little mistakes

    @MadLittleMods
    MadLittleMods committed May 12, 2022
    Configuration menu
    Copy the full SHA
    d7cf789 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Emphasize has *all* history as it's the key differentiator for that s… 

    …tatement compared to the rest in the list
    @MadLittleMods
    MadLittleMods committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    d016b7d View commit details
    Browse the repository at this point in the history

  2. Address markers being lost in timeline gaps (marker events as state) 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    2544a3f View commit details
    Browse the repository at this point in the history

  3. Formatting

    @MadLittleMods
    MadLittleMods committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    7258f64 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Small typos and other fixes

    @anoadragon453
    anoadragon453 authored Aug 9, 2022
    Configuration menu
    Copy the full SHA
    a828de3 View commit details
    Browse the repository at this point in the history

  2. Use json5 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b2b5b54 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Remove base graph 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    a7920fb View commit details
    Browse the repository at this point in the history

  2. ?ts is now specced 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    73f4143 View commit details
    Browse the repository at this point in the history

  3. Say explicit for current room version 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    92a7658 View commit details
    Browse the repository at this point in the history

  4. Say which query parameters are optional vs required 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    1cf7395 View commit details
    Browse the repository at this point in the history

  5. "Live timeline" so it's obvious 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    2433dfa View commit details
    Browse the repository at this point in the history

  6. Fix stable versions 

    See:

 - #2716 (comment)
 - #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    efbee43 View commit details
    Browse the repository at this point in the history

  7. Feature needs to be true 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    b4ba8c4 View commit details
    Browse the repository at this point in the history

  8. More clear phrasing 

    See:

 - #2716 (comment)
 - #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    7cde5cd View commit details
    Browse the repository at this point in the history

  9. Add annotation that older events are at the top of the graphs 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    8a50cbf View commit details
    Browse the repository at this point in the history

  10. A --> B is just where you want to import between 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    8286ca4 View commit details
    Browse the repository at this point in the history

  11. More than one reason for new room version 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    850e2f1 View commit details
    Browse the repository at this point in the history

  12. unioned with the state at the prev_event_id 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    3332ca8 View commit details
    Browse the repository at this point in the history

  13. State events are allowed 

    See:

 - #2716 (comment)
 - #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    3668193 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'matthew/msc2716' of github.com:matrix-org/matrix-doc in… 

    …to matthew/msc2716

Conflicts:
	proposals/2716-batch-send-historical-messages.md
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    c936c7b View commit details
    Browse the repository at this point in the history

  15. Unsaved merge conflict

    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    1d3f562 View commit details
    Browse the repository at this point in the history

  16. More clear image 

    See:

 - #2716 (comment)
 - #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    e593c20 View commit details
    Browse the repository at this point in the history

  17. Just use event types when referring to them 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    2c46547 View commit details
    Browse the repository at this point in the history

  18. Self-referential batches descoped to another MSC 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    f60c233 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Re-arrange to explain events and fields in table 

    Based on:

 - #2716 (comment)
 - https://github.com/matrix-org/matrix-spec-proposals/blob/43d224accc81a8335305d22790f7eb1d61f282f8/proposals/3672-ephemeral-location-streaming.md#proposal
    @MadLittleMods
    MadLittleMods committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    b081ec7 View commit details
    Browse the repository at this point in the history

  2. Fix some table formatting and better full examples

    @MadLittleMods
    MadLittleMods committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    d20455f View commit details
    Browse the repository at this point in the history

  3. Link to depth discussion 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    a8313bd View commit details
    Browse the repository at this point in the history

  4. Wrapping

    @MadLittleMods
    MadLittleMods committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    9d96c5c View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Fix direction

    @MadLittleMods
    MadLittleMods committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    991bd84 View commit details
    Browse the repository at this point in the history

  2. Remove namespace beacuse the event type is already the namespace 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    55551fc View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Fix heading structure and more words to describe the historical property 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1ee23d4 View commit details
    Browse the repository at this point in the history

  2. Explain when the messages in the example were sent 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e7e435d View commit details
    Browse the repository at this point in the history

  3. Clarify that you provide it next time 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    775d3d3 View commit details
    Browse the repository at this point in the history

  4. Clarify how it connects 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    6ccecd7 View commit details
    Browse the repository at this point in the history

  5. Fix endpoint path (no unstable) 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    af24a5f View commit details
    Browse the repository at this point in the history

  6. Add heading for new event types 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    10599cb View commit details
    Browse the repository at this point in the history

  7. Use m.room.insertion type name in mermaid graphs

    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    a6b5d8f View commit details
    Browse the repository at this point in the history

  8. Remove backticks from mermaid graphs

    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0642d88 View commit details
    Browse the repository at this point in the history

  9. Add more initial explanation 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    b18c214 View commit details
    Browse the repository at this point in the history

  10. Better DAG to match expectation image

    @MadLittleMods
    MadLittleMods committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    02b5f4b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Add example why you would use the historical content property 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    69bd287 View commit details
    Browse the repository at this point in the history

  2. Remove "full" 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5412e80 View commit details
    Browse the repository at this point in the history

  3. Fix historical typo 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    16a6a40 View commit details
    Browse the repository at this point in the history

  4. Explain that /batch_send does the insertion/batch dance for you 

    See #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    4a8f834 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Make it more clear what the drawbacks are 

    Pulling from my summary comments at:

 - #2716 (comment)
 - #2716 (comment)
    @MadLittleMods
    MadLittleMods committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e4193ff View commit details
    Browse the repository at this point in the history

  2. with should be without

    @MadLittleMods
    MadLittleMods committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    1fc8b6b View commit details
    Browse the repository at this point in the history