task(send queue): demote some assertions back to logged errors #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better safe than panicky.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4269 +/- ##
==========================================
+ Coverage 85.00% 85.03% +0.02%
==========================================
Files 274 274
Lines 29945 29952 +7
==========================================
+ Hits 25456 25470 +14
+ Misses 4489 4482 -7 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Nov 15, 2024
| ); | ||
|
|
||
| let prev_txn = was_being_sent.as_ref().map(|info| info.transaction_id.as_ref()); | ||
| if prev_txn != Some(transaction_id) { |
There was a problem hiding this comment.
The assert would have aborted execution here, while we now continue on, is that fine? Don't we want to perhaps return early?
There was a problem hiding this comment.
I think it would be a sign that the system is in a weird state, but the transaction_id passed as a parameter is the important value that is correct above all, so the current code is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better safe than panicky. I don't want a bad surprise when coming back from my weekend.