send queue: implement full unwedging of media uploads #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it can be reused in more contexts than just the sending of an event, but also for uploads.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4258 +/- ##
=======================================
Coverage 84.91% 84.92%
=======================================
Files 274 274
Lines 29768 29778 +10
=======================================
+ Hits 25278 25288 +10
Misses 4490 4490 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Nov 13, 2024
| assert!(local_echoes.is_empty()); | ||
|
|
||
| // Create the media to send (no thumbnails). | ||
| let filename = "rickroll.gif"; |
| // Create the media to send (no thumbnails). | ||
| let filename = "rickroll.gif"; | ||
| let content_type = mime::IMAGE_JPEG; | ||
| let data = b"Never gonna give you up".to_vec(); |
There was a problem hiding this comment.
I'm never gonna let you down Hywan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A media upload can fail forever (i.e. get wedged) at step 1 (thumbnail upload failed) or 2 (media upload failed), for instance because the media's too large and the server's refusing it. This implements unwedging for such cases, with a naive yet effective solution: since only at most one
QueuedRequestwith one of the three transaction IDs used during a upload may be active, we can unwedge all 3 in the database; at most one will have an effect, and the other two will be spurious 🤓Part of #4201