Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timeline): introduce the TimelineUniqueId #4111

Merged
merged 2 commits into from
Oct 16, 2024
Merged

feat(timeline): introduce the TimelineUniqueId #4111

merged 2 commits into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. chore(timeline): always increment the unique id to avoid issues with … 

    …stall IDs across timeline clears
    @bnjbvr
    bnjbvr committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6764918 View commit details
    Browse the repository at this point in the history

  2. refactor(timeline): introduce TimelineUniqueId as an opaque type fo… 

    …r the unique identifier

We can now use this type instead of passing a string, which means
there's no way to confuse oneself in methods like
`toggle_reaction_local`.

Changelog: Introduced `TimelineUniqueId`, returned by
`TimelineItem::unique_id()` and serving as an opaque identifier to use
in other methods modifying the timeline item (e.g. `toggle_reaction`).
    @bnjbvr
    bnjbvr committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6f3d880 View commit details
    Browse the repository at this point in the history