ci: detect unused dependencies #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
requested review from
jmartinesp and
andybalaam
and removed request for
a team
poljar
approved these changes
Oct 10, 2024
|
Oh, and you need to rebase to get #4108 for CI to fix itself. |
bnjbvr
force-pushed
the
bnjbvr/get-rid-of-unused-dependencies
branch
from
dc4c67e
to
d5706b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4107 +/- ##
==========================================
- Coverage 84.70% 84.66% -0.04%
==========================================
Files 269 269
Lines 28821 28821
==========================================
- Hits 24412 24401 -11
- Misses 4409 4420 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed there were a few unused dependencies; this removes them, and introduces a new check that will fail if there are any unused dependencies detected with
cargo-machete. Also marks one false positive that the tool can't detect.