-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Improvements for replies and edits #3627
Conversation
There is EventItemIdentifier for the same purpose. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3627 +/- ##
==========================================
- Coverage 84.21% 84.17% -0.05%
==========================================
Files 256 256
Lines 26553 26560 +7
==========================================
- Hits 22362 22356 -6
- Misses 4191 4204 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense! Ideally I'd like a small rename, but I can do it later if you'd prefer.
(Thanks in particular for the doc update!)
Signed-off-by: Kévin Commaille <[email protected]>
Each commit should be rather self-explanatory.
The motivation behind the second commit is for the use with
Room::restore_composer_draft
. When restoring a draft, but the edited/replied-to item is not available locally, that would result in two requests to the homeserver:Room::event()
to get the content of the edited/replied-to event to be able to display it in the UI.Timeline::{edit/replied_to}_info_from_event_id()
, which makes a request to the homeserver, to be able to callTimeline::edit/send_reply()
to send the event.By exposing the content of the edit/replied-to info, the client needs only to make a single homeserver request with
Timeline::{edit/replied_to}_info_from_event_id()
and can display the edited/replied-to event in the UI with it.