Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Remove assert_matches2 from regular dependencies #3626

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Jun 29, 2024

It was added as a regular dependency in #3517 but it is only used in tests.

It was added as a regular dependency in matrix-org#3517
but it is only used in tests.

Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested a review from a team as a code owner June 29, 2024 08:59
@zecakeh zecakeh requested review from bnjbvr and removed request for a team June 29, 2024 08:59
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (38a18c3) to head (b9510c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
+ Coverage   84.21%   84.22%   +0.01%     
==========================================
  Files         256      256              
  Lines       26553    26553              
==========================================
+ Hits        22362    22365       +3     
+ Misses       4191     4188       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit 374da76 into matrix-org:main Jul 1, 2024
38 checks passed
@zecakeh zecakeh deleted the crypto-assert-matches2 branch July 1, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants