send queue: mark ConcurrentRequestFailed
as recoverable
#3619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will still disable the room's send queue, but the embedder may then decide whether to re-enable the queue or not, based on network connectivity. Ideally, we'd implement some retry mechanism here too, but since we're at a different layer than the HTTP one, we can't get that "for free", so let the embedder decide what to do here.
No test because the only way to trigger this is likely by having an encrypted room, start a /member query for that room, then try to send an encrypted message into that room. Sending encrypted messages require lots of endpoints, and I'm not sure whether we have all the testing setup for that; I'll ask on the Matrix room. But since this is a tiny change in behavior (and we're likely to have other tweaks like that related to error handling, I don't think each new error type marked as recoverable would need to require its own test).
Part of #3361.