Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send queue: mark ConcurrentRequestFailed as recoverable #3619

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jun 27, 2024

This will still disable the room's send queue, but the embedder may then decide whether to re-enable the queue or not, based on network connectivity. Ideally, we'd implement some retry mechanism here too, but since we're at a different layer than the HTTP one, we can't get that "for free", so let the embedder decide what to do here.


No test because the only way to trigger this is likely by having an encrypted room, start a /member query for that room, then try to send an encrypted message into that room. Sending encrypted messages require lots of endpoints, and I'm not sure whether we have all the testing setup for that; I'll ask on the Matrix room. But since this is a tiny change in behavior (and we're likely to have other tweaks like that related to error handling, I don't think each new error type marked as recoverable would need to require its own test).


Part of #3361.

This will still disable the room's send queue, but the embedder may then
decide whether to re-enable the queue or not, based on network
connectivity. Ideally, we'd implement some retry mechanism here too, but
since we're at a different layer than the HTTP one, we can't get that
"for free", so let the embedder decide what to do here.
@bnjbvr bnjbvr requested a review from a team as a code owner June 27, 2024 14:46
@bnjbvr bnjbvr requested review from poljar and removed request for a team June 27, 2024 14:46
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.19%. Comparing base (d41af39) to head (93a28f6).

Files Patch % Lines
crates/matrix-sdk/src/send_queue.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
- Coverage   84.19%   84.19%   -0.01%     
==========================================
  Files         255      255              
  Lines       26416    26418       +2     
==========================================
+ Hits        22241    22242       +1     
- Misses       4175     4176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, a bit annoying that we don't have access to all the erorr data we want.

@bnjbvr bnjbvr merged commit 17d1832 into main Jul 1, 2024
38 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/send-queue-concurrent-request branch July 1, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants