Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): Rename the device keys property for Olm messages #3618

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Jun 27, 2024

Commit d41af39 implemented MSC4147, which puts the device keys into a Olm message. It failed to adhere to the unstable prefix proposed in the MSC:

Until this MSC is accepted, the new property should be named
org.matrix.msc4147.device_keys.

This patch fixes this.

Commit d41af39 implemented MSC4147, which puts the device keys into a
Olm message. It failed to adhere to the unstable prefix proposed in the
MSC:

> Until this MSC is accepted, the new property should be named
> org.matrix.msc4147.device_keys.

This patch fixes this.
@poljar poljar requested a review from a team as a code owner June 27, 2024 10:23
@poljar poljar requested review from Hywan and removed request for a team June 27, 2024 10:23
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.16%. Comparing base (d41af39) to head (ceec2a3).

Files Patch % Lines
crates/matrix-sdk-crypto/src/olm/session.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3618      +/-   ##
==========================================
- Coverage   84.19%   84.16%   -0.04%     
==========================================
  Files         255      255              
  Lines       26416    26416              
==========================================
- Hits        22241    22232       -9     
- Misses       4175     4184       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar enabled auto-merge (squash) June 27, 2024 19:15
@poljar poljar disabled auto-merge June 28, 2024 12:11
@bnjbvr bnjbvr removed the request for review from Hywan July 1, 2024 13:11
@poljar poljar merged commit eac2076 into main Jul 1, 2024
38 checks passed
@poljar poljar deleted the poljar/msc4147-fix branch July 1, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants