fix(sdk): when an encryption event is received, mark the room encryption as set #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… encryption as set. `RoomInfo::handle_state_event` will check this condition so we don't have to later ask the HS whether the room is encrypted or not through `room::is_encrypted()`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3602 +/- ##
==========================================
- Coverage 83.88% 83.88% -0.01%
==========================================
Files 254 254
Lines 26306 26309 +3
==========================================
Hits 22068 22068
- Misses 4238 4241 +3 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Jun 25, 2024
| @@ -566,6 +566,10 @@ impl RoomListItem { | |||
| self.inner.init_timeline_with_builder(timeline_builder).map_err(RoomListError::from).await | |||
| } | |||
|
|
|||
| async fn is_encrypted(&self) -> bool { | |||
There was a problem hiding this comment.
Please add a doc comment, documentation is nowadays visible over the FFI, also please document that the correctness of this might depend on specifying m.room.encryption as required state.
There was a problem hiding this comment.
Let me know if 0162f6b works for you.
poljar
deleted the
fix/encryption-events-should-mark-encryption-state-as-set
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoomInfo::handle_state_event(...)will check this condition so we don't have to later ask the HS whether the room is encrypted or not throughroom::is_encrypted().Also, as we need some way to get this info in the room list in our clients, I also added 2 ways of doing this the FFI crate, one through
RoomInfoand another one throughRoomListItem. If we don't want the duplication I can get rid of one of them.This bug was found by @poljar, thanks for pointing it out!
Signed-off-by: